[FFmpeg-devel] [PATCH] noise_bsf: mention the parameter in the docs

Michael Niedermayer michaelni at gmx.at
Mon Dec 1 23:48:45 CET 2014


On Mon, Dec 01, 2014 at 11:09:55PM +0100, Christophe Gisquet wrote:
> Hi,
> 
> 2014-11-30 17:08 GMT+01:00 Michael Niedermayer <michaelni at gmx.at>:
> > On Sun, Nov 30, 2014 at 02:45:54PM +0100, Christophe Gisquet wrote:
> > its the inverse of the amount, so smaller numbers should result in
> > more noise with 1 resulting in the maximum
> 
> True, the modulo means the smaller the value, the more frequent it
> happens. State isn't updated from that modulo, so indeed I've mistaken
> it for a seed.
> 
> Hopefully, the attached patch addresses both the need for correct
> explanation as well as Lou's comment.
> 
> -- 
> Christophe

>  bitstream_filters.texi |   12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 37da00c55ef9efa5f85d26903cf403a23d147edf  0004-noise_bsf-mention-the-parameter-in-the-docs.patch
> From 7e6cc5a8c82cde93c6138081cee634deca6d8378 Mon Sep 17 00:00:00 2001
> From: Christophe Gisquet <christophe.gisquet at gmail.com>
> Date: Sun, 30 Nov 2014 11:59:22 +0100
> Subject: [PATCH 4/4] noise_bsf: mention the parameter in the docs
> 
> This looks more like a seed than an amount, as the variable name
> could lead to think.
> ---
>  doc/bitstream_filters.texi | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141201/7b449afb/attachment.asc>


More information about the ffmpeg-devel mailing list