[FFmpeg-devel] [PATCH] avfilter/vf_tinterlace: Favor using standard timebases for the output

[Vittorio Giovara]

On Mon, Dec 1, 2014 at 8:04 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> Inspired by discussion with kierank
> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>

Missing a 'Reported by' tag I believe.

> ---
>  libavfilter/tinterlace.h    |    1 +
>  libavfilter/vf_tinterlace.c |   24 ++++++++++++++++++++++--
>  2 files changed, 23 insertions(+), 2 deletions(-)

This leaves vf_interlace broken, and having working timestamps was
among the main reasons of having a spin-off filter. Whatever the fix
ends up being, please apply it there too.

> diff --git a/libavfilter/vf_tinterlace.c b/libavfilter/vf_tinterlace.c
> index 133f073..b368e7c 100644
> --- a/libavfilter/vf_tinterlace.c
> +++ b/libavfilter/vf_tinterlace.c
> @@ -35,6 +35,7 @@
> +static const AVRational standard_tbs[] = {
> +    {1, 25},
> +    {1001, 30000},
> +};

This effectively limits interlacing to two framerates. What about pure
30i? What about some future (or past) framerate we didn't think of?
Listing all possible framerate combinations is simply not
maintainable.

If you reeeeeeally want interlaced vfr why don't just add a filter
option like "keep_timebase" or something? Imho, it would be enough to
revert the broken patches.
-- 
Vittorio