[FFmpeg-devel] [PATCH 3/4] ituh263dec: Optimize new RL_VLC based decoding.

[Reimar Döffinger]

On Sun, Aug 31, 2014 at 08:14:04PM +0200, Michael Niedermayer wrote:
> On Sun, Aug 31, 2014 at 08:06:54PM +0200, Reimar Döffinger wrote:
> > On Sun, Aug 31, 2014 at 07:09:13PM +0200, Michael Niedermayer wrote:
> > > On Sun, Aug 31, 2014 at 04:48:43PM +0200, Reimar Döffinger wrote:
> > > > @@ -549,11 +549,8 @@ retry:
> > > >              av_log(s->avctx, AV_LOG_ERROR, "run overflow at %dx%d i:%d\n", s->mb_x, s->mb_y, s->mb_intra);
> > > >              return -1;
> > > >          }
> > > > -        j = scan_table[i];
> > > > +        j = scan_table[i-1];
> > > 
> > > the - 1 feels avoidable
> > 
> > I have no good idea how so far.
> 
> cant i be offset at entry & exit of the loop ?
> or
> scan_table be offset by -1 ?

*facepalm*. Yes, something like that should be possible.

> anyway not really important, its faster as is than before so this is
> maybe better in a seperate later patch

Considering how many bugs I had in this one, yes,
I rather have this one out and tested before I break
it again :)