[FFmpeg-devel] [PATCH] Fix MSVC warnings about possible value truncation.

[Peter Kasting]

On Fri, Aug 29, 2014 at 4:34 PM, Michael Niedermayer <michaelni at gmx.at>
wrote:

> I think a key question is, what is the rate of warnings that point to
> actual bugs vs. warnings that do not point to actual bugs.
> is any of these changes fixing an actual bug ?


As I said, I'm not familiar enough with the code to know for sure.  I can
tell you that some of the warning sites in this patch looked suspicious to
me, and that this warning has already caught real bugs in other libraries
Chromium uses (for example, we found some places in Blink that do Unicode
case-folding unsafely).  In another mail I gave an argument why I think the
sorts of things this warning points out are things that should always be
considered explicitly.

In the end, we're trying to turn the warning on across Chromium because we
believe it's worth the cost and will result in safer and more bug-free
code.  If the FFMPEG community disagrees, we can still build FFMPEG with a
library-specific warning disable, but I personally think that would be a
worse outcome for the FFMPEG codebase.

PK