[FFmpeg-devel] [PATCH] added synchronous KLV codec ID and mpegts PAT and PMT descriptors as specified in stanag4609 annex C

Carl Eugen Hoyos cehoyos at ag.or.at
Sat Aug 30 00:41:58 CEST 2014


paolovergori <webinostestbed <at> gmail.com> writes:

> +    AV_CODEC_ID_SMPTE_KLV_SYNC  = MKBETAG('K','L','V','S'),

Please just add this line, do not reindent the 
other defines, at least not in the same commit.

>      { MKTAG('K','L','V','A'), AVMEDIA_TYPE_DATA, AV_CODEC_ID_SMPTE_KLV },
> +    { MKTAG('K', 'L', 'V', 'S'), AVMEDIA_TYPE_DATA, 
> AV_CODEC_ID_SMPTE_KLV_SYNC },
>      { MKTAG('I','D','3',' '), AVMEDIA_TYPE_DATA, AV_CODEC_ID_TIMED_ID3 },

Please use the same coding style as the 
surrounding code.

> +            if (st->codec->codec_id == AV_CODEC_ID_SMPTE_KLV_SYNC) {
> +                *q++ = 0x26;
> +                *q++ = 0x09;
> +                *q++ = 0x01;
> +                *q++ = 0x00;
> +                *q++ = 0xFF;
> +                *q++ = 'K';
> +                *q++ = 'L';
> +                *q++ = 'V';
> +                *q++ = 'A';
> +                *q++ = 0x00;
> +                *q++ = 0x0f;
> +                *q++ = 0x27;
> +                *q++ = 0x09;
> +                *q++ = 0xC0;
> +                *q++ = 0x00;
> +                *q++ = 0x00;//0x04;
> +                *q++ = 0xC0;
> +                *q++ = 0x00;
> +                *q++ = 0x00;//0x01;
> +                *q++ = 0xC0;
> +                *q++ = 0x00;
> +                *q++ = 0x00;

I suspect some comments about what is written here 
would be nice.

Carl Eugen



More information about the ffmpeg-devel mailing list