[FFmpeg-devel] [PATCH 2/3] build: rely on pkg-config for libx264 probing

[Clément Bœsch]

On Thu, Aug 28, 2014 at 01:18:55PM +0000, Carl Eugen Hoyos wrote:
> Clément Bœsch <u <at> pkh.me> writes:
> 
> > > Did you try the patch with pkg-config only detection?
> > > 
> > > And try to add --pkg-config=true to trick the detect function.
> > 
> > So, I did try myself
> 
> Sorry, I was away and still didn't test all new 
> tickets.
> 
> > [~/src/ffmpeg]☭ dash ./configure --disable-everything 
> > --enable-gpl --enable-libx264 --pkg-config=/bin/true
> 
> > --extra-ldflags=-lx264
> 
> The extra-ldflags should not be necessary.
> 

Well, it's incomplete depending on the situation so we don't want it in
the configure (Cf my mail about testing such things) and you're probably
setting --extra-ldflags already for your custom paths.

Also, you need to add --pkg-config=true anyway, so you can do the effort
to add -lx264 as well.

> I still wonder why --pkg-config=/bin/true is 
> necessary: If another version (than the one intended 
> by the user) is found then he has a bad system 
> installation (and has to use above work-around). 
> But if no installation can be found, the work-around 
> should be tested by configure.

Unless I misunderstood the question, it will; --pkg-config=true will just
make the fake pkg-config raise no flags, and then compilation will be
tried with those empty flags (and the --extra-{c,ld}flags).

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140828/8800ed68/attachment.asc>