[FFmpeg-devel] [PATCH] lavf/mp3enc: don't abort if audio packets can't be buffered

[Michael Niedermayer]

On Tue, Aug 26, 2014 at 09:36:38PM -0300, James Almer wrote:
> Instead skip the picture streams and flush the queued audio packets.
> Should address ticket #3851.
> 
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
> This is more a workaround than a "fix" to the issue, with the intent of 
> not aborting the entire muxing process just because a picture couldn't 
> be written to the id3v2 tag.

LGTM

maybe the code should be extended by at least a threashold of
how much can be buffered so theres a limit and it doesnt depend on
OOM

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140827/ed60b7e4/attachment.asc>