[FFmpeg-devel] [PATCH 1/2] lavc/flacdsp: document limitations of the LPC encoder

James Darnley james.darnley at gmail.com
Thu Aug 14 17:14:14 CEST 2014


State that the maximum value of order is 32.  This limit is used in both C and
x86 assebly code.
---
 libavcodec/flacdsp.h |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/libavcodec/flacdsp.h b/libavcodec/flacdsp.h
index 272cf2a..e8487c8 100644
--- a/libavcodec/flacdsp.h
+++ b/libavcodec/flacdsp.h
@@ -27,6 +27,13 @@ typedef struct FLACDSPContext {
                            int len, int shift);
     void (*lpc)(int32_t *samples, const int coeffs[32], int order,
                 int qlevel, int len);
+    /**
+     * This function supports a maximum order of 32.
+     *
+     * This limit is used:
+     * - when CONFIG_SMALL is 0 to unroll a loop in the C template.
+     * - when SSE4 (or newer) is available on x86 to unroll a copy loop.
+     */
     void (*lpc_encode)(int32_t *res, const int32_t *smp, int len, int order,
                        const int32_t *coefs, int shift);
 } FLACDSPContext;
-- 
1.7.9



More information about the ffmpeg-devel mailing list