[FFmpeg-devel] [PATCH] swresample: Add AVFrame based API

[Michael Niedermayer]

On Mon, Aug 11, 2014 at 12:53:30PM -0700, Timothy Gu wrote:
> On Aug 10, 2014 4:49 PM, "Michael Niedermayer" <michaelni at gmx.at> wrote:
[...]
> > + * to an internal FIFO buffer, to be returned at the next call to this
> function
> > + * or to swr_convert() or to swr_convert_frame().
> 
> at the next call to this function or to swr_convert().
> 
> > + *
> > + * If converting sample rate, there may be data remaining in the internal
> > + * resampling delay buffer. swr_get_delay() tells the number of
> > + * remaining samples. To get this data as output, call this function or
> > + * swr_convert() with NULL input.
> > + *
> > + * If the SwrContext configuration does not match the output and
> > + * input AVFrame settings the conversion does not take place and
> depending on
> > + * which AVFrame is not matching AVERROR_OUTPUT_CHANGED,
> AVERROR_INPUT_CHANGED
> 
> > + * or AVERROR_OUTPUT_CHANGED|AVERROR_INPUT_CHANGED is returned.
> 
> or the result of a bitwise-OR of them is returned.

both changed


> 
> > + *
> > + * @see swr_delay()
> > + * @see swr_convert()
> > + * @see swr_get_delay()
> > + *
> > + * @param swr             audio resample context
> > + * @param output          output AVFrame
> > + * @param input           input AVFrame
> > + * @return                0 on success, AVERROR on failure or nonmatching
> > + *                        configuration.
> > + */
> > +int swr_convert_frame(SwrContext *swr,
> > +                      AVFrame *output, AVFrame *input);
> > +
> > +/**
> > + * Configure or reconfigure the SwrContext using the information
> > + * provided by the AVFrames.
> > + *
> 
> > + * The original resampling context is reset even on failure.
> > + * The function calls swr_close() internally if the context is open.
> 
> swr_close does nothing. Is it appropriate to list it here? Also, I don't
> think SwrContext has a concept of open or close.

it has a concept of initialized vs not initialized
and close returns it to the non initilaized state


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140811/d2177364/attachment.asc>