[FFmpeg-devel] [PATCH] libavformat/icecast.c Add Icecast protocol

Michael Niedermayer michaelni at gmx.at
Sun Aug 3 23:56:48 CEST 2014


On Sun, Aug 03, 2014 at 11:53:21PM +0200, Marvin Scholz wrote:
> >>+    if (user)
> >>+        av_freep(&user);
> >>+    if (headers)
> >>+        av_freep(&headers);
> >
> >pointless ifs
> 
> I'm pretty sure I need it, since there are possible cases where
> these are not allocated and I can't free them.

av_freep() should be safe to be used with NULL

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct answer.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140803/6cac2140/attachment.asc>


More information about the ffmpeg-devel mailing list