[FFmpeg-devel] [PATCH] Add a gamma flag to exr loader to avoid banding

Jimmy Christensen jimmy at ghost.dk
Tue Apr 29 08:49:38 CEST 2014


Got a little late into the discussion of it all. My main concern was 
about the speed of the new code compared to the old, however it seem 
that the new code is even faster than the old :)

I'm not sure that I like that it's default with gamma 2.2. Personally I 
would rather have it defaults to gamma 1.0 (no changes). Have too much 
bad experience with default values like this :)

When people apply gamma etc. they should know what they are doing. Also 
in the future when floating point pixel format is supported, you don't 
want to apply gamma before applying eg. a lin2log filter before applying 
a LUT.

Hilsen
Jimmy Christensen
Developer
Ghost A/S

On 28/04/14 19:59, Michael Niedermayer wrote:
> On Mon, Apr 28, 2014 at 11:43:16AM -0300, Gonzalo Garramuno wrote:
>>
>> Ping.  Just checking if the patch will be (pretty please) accepted or not.
>
> patience
>
> First it seems to still have a bug
> it fails fate
> --- ./tests/ref/fate/exr-slice-raw      2014-04-28 04:14:37.849375679 +0200
> +++ tests/data/fate/exr-slice-raw       2014-04-28 19:50:27.430558597 +0200
> @@ -1,2 +1,2 @@
>   #tb 0: 1/25
> -0,          0,          0,        1,  3169800, 0x6a356d0d
> +0,          0,          0,        1,  3169800, 0x2cfefd25
>
> Second, some people seem to dislike it, and some (me and you at least)
> seem to think its ok until full float pixel format support
> exists.
>
> theres noone listed in MAINTAINERs for exr
> does anyone volunteer to maintain exr ?
>
> if no and noone is strongly against then ill apply this patch once
> it works but not before 3 days.
> if someone volunteers as maintainer for exr then its his decission
>
> iam also CCing the author of the exr code and paul who was actively
> working on exr, maybe either of them want to maintain the code or have
> comments
>
> Thanks
>
> [...]
>


More information about the ffmpeg-devel mailing list