[FFmpeg-devel] [PATCH]Use correct msvc type specifiers for ptrdiff_t and size_t

Ronald S. Bultje rsbultje at gmail.com
Wed Apr 23 22:14:55 CEST 2014


Hi,

On Wed, Apr 23, 2014 at 3:41 PM, wm4 <nfxjfg at googlemail.com> wrote:

> On Wed, 23 Apr 2014 15:28:56 +0200
> Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
>
> > Hi!
> >
> > Attached patch intends to fix crashes when using printing debug (and
> error)
> > messages after msvc compilation, fixes ticket #3472.
> > I did not test myself.
> >
> > Please comment, Carl Eugen
>
> This requires changes in every single log call. Wouldn't it be better
> to provide a wrapper around snprintf on MSVC that automatically
> replaces the printf specifiers as needed and pretends to be C99?
>
> (In fact there's already a wrapper, but it leaves the format string
> alone currently.)


If we intend to provide a msvc-runtime-wrapper, we could just as well fork
mingw.

I think the patch is fine.

Ronald


More information about the ffmpeg-devel mailing list