[FFmpeg-devel] [PATCH] Change type to 16 bit.

Nicolas George george at nsup.org
Tue Apr 22 23:46:56 CEST 2014

Le tridi 3 floréal, an CCXXII, Reimar Döffinger a écrit :
> That kind of is the question.

Well, I can confirm that your reasoning seems logical to me too.

> I suspect it won't really happen, but in that case
> having the check doesn't really make sense.

It could probably happen with a specially crafted file. It does not seems it
would cause a security issue, though, only garbled decoding.

> The compiler complains because the condition can
> never be true.

This part I do not understand: if I read the code correctly, the check
against V_MAX_PARTITIONS (= 1 << 20) happens before ptns_to_read is defined,
and the begin and end fields are wide enough.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140422/b4dac4b3/attachment.asc>

More information about the ffmpeg-devel mailing list