[FFmpeg-devel] [PATCH 1/9] lavf: add AVIO_FLAG_EXCL flag system.
Reimar Döffinger
Reimar.Doeffinger at gmx.de
Sat Apr 19 08:47:35 CEST 2014
On 18.04.2014, at 23:35, Nicolas George <george at nsup.org> wrote:
> Le septidi 27 germinal, an CCXXII, Michael Niedermayer a écrit :
>>> libavformat/avio.c | 12 +++++++++++-
>>> libavformat/avio.h | 18 ++++++++++++++++++
>>> libavformat/url.h | 1 +
>>> 3 files changed, 30 insertions(+), 1 deletion(-)
>> LGTM
>
> Thanks for the review. I will leave a few more days for people who may want
> to comment on the API itself, especially the EXCL / EXCL_LOOSE part, before
> requesting a merge.
I am not really sure we'll be happy with it in the long term, also because the "normal" default behaviour may differ e.g. when thinking of files on Windows.
But I don't have a better idea, so we'll just have to deal with it when we actually find issues.
> By the way, if people would have preferred the six trivial ones bundled
> together, just tell me for future similar cases.
I kind of prefer having things like adding new flags to existing structs as one patch, but it deosn't matter much.
More information about the ffmpeg-devel
mailing list