[FFmpeg-devel] Patch: Inline asm fixes for Intel compiler on Windows

[Michael Niedermayer]

On Mon, Apr 14, 2014 at 03:23:15PM +1000, Matt Oliver wrote:
> > i could apply it but it feels wrong to apply things to mplayer that
> > where posted to ffmpeg and not mplayer. Please submit it to mplayer
> > (and in case noone reviews/applies it there, ping me and ill do it)
> >
> 
> Fair enough and thanks, I submitted it to mplayer mailing list so well see
> how that goes.
> 
> On an additional note I was playing with some icl settings and found a
> small error. Seems idct_sse2_xvid.c has a stray inline declaration on one
> of its functions. The standard or mmx/mmext versions dont have the inline
> just the sse2 version. Given this is in a .c file and the function is used
> externally the inline has no affect and seems to cause icl to not export
> the function properly. Attached is a small patch.

>  idct_sse2_xvid.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 6f9f511a83f3fee3b3c4ed0dc1b3538436266183  idct-Remove-redundant-inline-from-xvid_sse.patch
> From 77ffd0464c8b24b1c87289f5c5c4695e2921309a Mon Sep 17 00:00:00 2001
> From: Matt Oliver <protogonoi at gmail.com>
> Date: Mon, 14 Apr 2014 15:15:59 +1000
> Subject: [PATCH] idct: Remove redundant inline from xvid_sse
> 
> ---
>  libavcodec/x86/idct_sse2_xvid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/x86/idct_sse2_xvid.c b/libavcodec/x86/idct_sse2_xvid.c
> index e1878fa..a02bfae 100644
> --- a/libavcodec/x86/idct_sse2_xvid.c
> +++ b/libavcodec/x86/idct_sse2_xvid.c
> @@ -343,7 +343,7 @@ DECLARE_ASM_CONST(16, int32_t, walkenIdctRounders)[] = {
>      "movdqa   %%xmm6, 4*16("dct")     \n\t" \
>      "movdqa   "SREG2", 7*16("dct")    \n\t"
>  
> -inline void ff_idct_xvid_sse2(short *block)
> +void ff_idct_xvid_sse2(short *block)

fixed differently

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140414/c9db08ec/attachment.asc>