[FFmpeg-devel] [PATCH] flac demuxer: improve seeking

[Michael Niedermayer]

On Mon, Apr 14, 2014 at 02:12:14PM +0000, Rainer Hochecker wrote:
> Rainer Hochecker <rainer.hochecker <at> onlinehome.de> writes:
> 
> > 
> > Yes, av_read_frame is not a good idea to use here. It does not give the
> > exact starting position which is the reason the results are slightly
> > different. Also the current parser sometimes returns eof after having set
> > file pos to some arbitrary position.
> > I think I need to write some function which syncs to starting point of a
> > header/packet. 
> > 
> 
> I have updated the pull request on Github. The results are identical now
> apart from negative return values which do not occur with read_timestamp. I
> updated ref data for fate in a separate commit.

this looks much better

I think the parser should only set pts if PARSER_FLAG_USE_CODEC_TS is
set though
Otherwise a demxer that has its own timestamps and uses the flac
parser (not sure such a case exists) could break

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140414/8f541e17/attachment.asc>