[FFmpeg-devel] [PATCH] Handle initial RTMP chunk size packet

[Stephan Soller]

On 04/14/2014 02:41 PM, Michael Niedermayer wrote:
> On Sun, Apr 13, 2014 at 01:52:09PM +0200, Stephan Soller wrote:
>> On 04/13/2014 01:29 PM, Nicolas George wrote:
>>> Le quartidi 24 germinal, an CCXXII, Stephan Soller a écrit :
>>>> Good point. I didn't notice the handle_chunk_size() function before.
>>>> Changed the code to use that function and it works quite well.
>>>
>>> I was not sure it would. So much the better if it does.
>>>
>>>> However the handle_chunk_size() function is declared further down in
>>>> the C file so I either need to add a forward declaration or move the
>>>> read_connect() function downwards. Which of the two would be the
>>>> preferred way?
>>>
>>> In this particular case, I suspect a forward declaration would be better to
>>> reduce the diff with the fork, but it does not matter much.
>>>
>>> Regards,
>>
>> Done, updated patch attached. It now uses the handle_chunk_size()
>> function and adds a forward declaration at the top the the file
>> (before the first function definition).
>>
>> Tested it with the 2.2 and master branch.
>
> applied to master and backported to release/2.2
>
> thanks
>
> [...]

Thanks for the quick action. :)

Happy programming
Stephan