[FFmpeg-devel] [PATCH] Handle initial RTMP chunk size packet

Stephan Soller stephan.soller at helionweb.de
Sun Apr 13 13:52:09 CEST 2014


On 04/13/2014 01:29 PM, Nicolas George wrote:
> Le quartidi 24 germinal, an CCXXII, Stephan Soller a écrit :
>> Good point. I didn't notice the handle_chunk_size() function before.
>> Changed the code to use that function and it works quite well.
>
> I was not sure it would. So much the better if it does.
>
>> However the handle_chunk_size() function is declared further down in
>> the C file so I either need to add a forward declaration or move the
>> read_connect() function downwards. Which of the two would be the
>> preferred way?
>
> In this particular case, I suspect a forward declaration would be better to
> reduce the diff with the fork, but it does not matter much.
>
> Regards,

Done, updated patch attached. It now uses the handle_chunk_size() 
function and adds a forward declaration at the top the the file (before 
the first function definition).

Tested it with the 2.2 and master branch.

Happy programming
Stephan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-avformat-rtmpproto-Added-handling-of-an-initial-RTMP-v2.patch
Type: text/x-patch
Size: 1556 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140413/a9268df9/attachment.bin>


More information about the ffmpeg-devel mailing list