[FFmpeg-devel] Patch: Inline asm fixes for Intel compiler on Windows

Matt Oliver protogonoi at gmail.com
Sun Apr 13 09:24:54 CEST 2014


On 11 April 2014 01:48, Michael Niedermayer <michaelni at gmx.at> wrote:

> On Thu, Apr 10, 2014 at 05:28:30PM +1000, Matt Oliver wrote:
> > Heres the patch to exclude BRANCHLESS_GET_CABAC under icl. Its added to
> the
> > existing BROKEN_COMPILER which is in turn added to h265_i386.h. This is
> the
> > simplest and cleanest way to add it to the existing code. Based on the
> > issues in ticket 2999 that resulted in BROKEN_COMPILER being were it is i
> > believe that this patch is correct for the existing use of
> BROKEN_COMPILER
> > (its most certainly correct for icl).
>
> >  cabac.h     |    5 +++--
> >  h264_i386.h |    4 ++--
> >  2 files changed, 5 insertions(+), 4 deletions(-)
> > ca53f2f6166c843a6effa5c9760f45bacd74ba11
>  Exclude-broken-get_cabac-under-icl.patch
> > From c40e94e70c618a59c5682eb2ef884cd085033cf9 Mon Sep 17 00:00:00 2001
> > From: Matt Oliver <protogonoi at gmail.com>
> > Date: Thu, 10 Apr 2014 17:19:11 +1000
> > Subject: [PATCH] Exclude broken get_cabac under icl.
>
> applied
>
> thanks
>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> The worst form of inequality is to try to make unequal things equal.
> -- Aristotle
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>
Well the last thing that is required for icl compatibility now is the
libmpcodec patch. The first 3 have been applied in mplayer upstream but
havnt been synced to ffmpeg yet. The last remaining patch is attached. This
patch adds the named constraints to libmpcodec inline asm which is required
for icl (as done previously in ffmpeg) and is potentially also useful for
lto as per previous discussion on using named constraints with link time
optimization.
Is there someone here who can look over it and apply it upstream or do I
need to submit it directly to mplayer?
With this last patch (and the upstream sync) ffmpeg will finally have
complete icl asm support.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 4-4-Fix-libmpcodecs-inline-asm-on-ICL-part-2.patch
Type: application/octet-stream
Size: 3378 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140413/115e8a6d/attachment.obj>


More information about the ffmpeg-devel mailing list