[FFmpeg-devel] [PATCH] lavd/avdevice: add control message enums

[Lukasz Marek]

On 10.04.2014 23:48, Nicolas George wrote:
> Le primidi 21 germinal, an CCXXII, Lukasz Marek a écrit :
>> >From 8b003ade41a27856230c77d2883c6efa7e75916b Mon Sep 17 00:00:00 2001
>> From: Lukasz Marek <lukasz.m.luki2 at gmail.com>
>> Date: Thu, 10 Apr 2014 00:47:32 +0200
>> Subject: [PATCH] lavd: add control message enums
>>
>> ---
>>   libavdevice/avdevice.h | 49 +++++++++++++++++++++++++++++++++++++++++++++++--
>>   1 file changed, 47 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavdevice/avdevice.h b/libavdevice/avdevice.h
>> index e194663..7db718f 100644
>> --- a/libavdevice/avdevice.h
>> +++ b/libavdevice/avdevice.h
>> @@ -112,6 +112,14 @@ typedef struct AVDeviceRect {
>>       int height; /**< height */
>>   } AVDeviceRect;
>>
>
>> +typedef union AVDeviceValue {
>> +    uint64_t u64;
>> +    int64_t i64;
>> +    double dbl;
>> +    const char *str;
>> +    AVRational q;
>> +} AVDeviceValue;
>
> Can you explain the point of this union? As far as I can see, you could just
> as easily document the exact type for data.

My mistake, removed.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavd-add-control-message-enums.patch
Type: text/x-patch
Size: 2903 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140411/af82c99f/attachment.bin>