[FFmpeg-devel] [PATCH 07/19 v2] avformat/hls: parse ID3 timestamps for elementary audio streams

[Anssi Hannula]

10.04.2014 12:41, Schenk, Michael kirjoitti:
> Hi,

Hi,

> first of all thanks for the effort on HLS for supporting alternative rendition! However
> it looks like certain HLS servers do not like the seek which was added in the libavformat/hls.c
> open_input(...) function.
> 
> Example Anevia Encrypted URL: http://demo.anevia.com:3128/vod/disk1/content2/ss-hls-c-fixed/content2.m3u8
> 

Oops, sorry.

> Failure Log:
> 
> request: GET /vod/disk1/content2/ss-hls-c-fixed/content2-audio%3D96000-video%3D257000-1.ts HTTP/1.1
> User-Agent: Lavf/55.36.102
> Accept: */*
> Connection: close
> Host: demo.anevia.com:3128
> 
> 
> header='HTTP/1.0 200 OK'
> http_code=200
> header='Date: Thu, 10 Apr 2014 09:15:46 GMT'
> header='Server: Apache/2.2.24 (Unix) mod_ssl/2.2.24 OpenSSL/0.9.8g DAV/2 PHP/5.3.24 IISMS/4.0 mod_wsgi/3.4 Python/2.7'
> header='Last-Modified: Tue, 11 Mar 2014 22:19:21 GMT'
> header='Content-Length: 153792'
> header='ETag: "28000090-1377-4f45c1ca2e646;153792"'
> header='Accept-Ranges: bytes'
> header='Content-Type: video/MP2T'
> header='X-Cache: MISS from demo.anevia.com'
> header='X-Cache-Lookup: MISS from demo.anevia.com:3128'
> header='Via: 1.1 demo.anevia.com:3128 (squid/2.7.STABLE9)'
> header='Connection: close'
> header=''
> Unable to seek to offset 0 of HLS segment 'http://demo.anevia.com:3128/vod/disk1/content2/ss-hls-c-fixed/content2-audio%3D96000-video%3D257000-1.ts'
> Failed to open segment of playlist 0
> Error when loading first segment 'http://demo.anevia.com:3128/vod/disk1/content2/ss-hls-c-fixed/content2-audio%3D96000-video%3D257000-1.ts'
> 
> Because it is not needed I propose to remove it and this will solve the issue.
> 
> Please find attached a patch

Instead of removing it I disabled it for encrypted streams for now. I
also fixed another similar case that affected audio-only streams.

Thanks.

> Feedback welcome!
> 
> Cheers
> 
> Michael
> 
> 
> 
> 
> -----Ursprüngliche Nachricht-----
> Von: ffmpeg-devel-bounces at ffmpeg.org [mailto:ffmpeg-devel-bounces at ffmpeg.org] Im Auftrag von Anssi Hannula
> Gesendet: Sonntag, 6. April 2014 16:58
> An: ffmpeg-devel at ffmpeg.org
> Betreff: Re: [FFmpeg-devel] [PATCH 07/19 v2] avformat/hls: parse ID3 timestamps for elementary audio streams
> 
> 05.04.2014 15:20, Anssi Hannula kirjoitti:
>> HLS provides MPEG TS timestamps via ID3 tags in the beginning of each 
>> segment of elementary audio streams.
>>
>> v2: fix issues with streams that have multiple ID3 tags
>>
>> Signed-off-by: Anssi Hannula <anssi.hannula at iki.fi>
>> ---
>>
>> Hi all,
>>
>> and sorry for the delay in getting this patchset in.
>>
>> I plan to apply the patchset (minus subtitle parts) later today or 
>> tomorrow, unless any issues are found (by me or anyone here).
> 
> Done, now let's see how much broke.
> 
>> The only major change is that I've dropped the separate hls_id3_audio 
>> subdemuxer again due to the various timestamp issues and the ID3 
>> timestamp mangling is now done in the hls demuxer itself. So this is 
>> similar to what the first version of the patchset had, except that the 
>> issues with it have been fixed.
>>
>> The patch in this message is the major updated part of this patchset 
>> version. intercept_id3() contains most of the new code, other parts 
>> were mostly present in one of the previous versions of the patchset.
>>
>> For other parts I've applied the changes previously mentioned and/or 
>> discussed.
>>
>> The full patchset is at:
>> https://github.com/anssih/FFmpeg/commits/hls-patchset-wip-3
>> and with extra commits (mostly subtitles) that will remain in TODO:
>> https://github.com/anssih/FFmpeg/commits/hls-patchset-wip-3-extra
>>
>> What is missing from the subtitle parts is to see if they could be 
>> handled in a cleaner way (i.e. without the demuxer reopening hacks), 
>> and some additional testing. I don't likely have time to work on that 
>> for at least the next few weeks, though, but patches welcome of course.
> 
> 
> --
> Anssi Hannula
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 


-- 
Anssi Hannula