[FFmpeg-devel] [PATCH 02/10] x86: dcadsp: implement SSE lfe_dir

Michael Niedermayer michaelni at gmx.at
Sun Apr 6 21:10:30 CEST 2014

On Sun, Apr 06, 2014 at 06:46:30PM +0200, Christophe Gisquet wrote:
> 2014-04-06 18:35 GMT+02:00 James Almer <jamrial at gmail.com>:
> > Ideally, this should be fixed on x86inc so movh expands to movq or movlps
> > depending on the requested instruction set, so this doesn't happen again.
> Exactly. Actually, I had already made this request (during my work on
> he-aac), but it was rejected, as well as this patch:

> http://pastebin.com/5Ps8rcjF

i dont remember seeing this patch before, maybe ive forgotten though

> The basic reason was "we don't want to bother with SSE in our code",
> which also meant "just drop your SSE version".

IMHO, SSE is fine if someone bothers writing the code and is willing
to maintain it


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140406/a419ad8c/attachment.asc>

More information about the ffmpeg-devel mailing list