[FFmpeg-devel] [PATCH]Set Matroska private data when muxing Prores

[Michael Niedermayer]

On Sun, Apr 06, 2014 at 03:23:38AM +0200, Carl Eugen Hoyos wrote:
> On Saturday 05 April 2014 02:20:04 pm Michael Niedermayer wrote:
> > On Mon, Mar 31, 2014 at 01:43:01AM +0200, Carl Eugen Hoyos wrote:
> > > I don't think ticket #3434 is valid but the specification requires Prores
> > > in mkv to set private data to the "fourcc as found in MP4".
> > > http://matroska.org/technical/specs/codecid/index.html
> 
> > > +        } else if (codec->codec_id == AV_CODEC_ID_PRORES &&
> > > +                   ff_codec_get_id(ff_codec_movvideo_tags,
> > > codec->codec_tag) == AV_CODEC_ID_PRORES) {
> > >
> > > +            avio_write(dyn_cp, (uint8_t *)&codec->codec_tag, 4);
> >
> > this will fail on big endian
> 
> New patch attached.
> 
> > also, have you compared against some mkv generated by some other
> > software ? (to make sure what we store matches in length and content)
> 
> I was hoping you could confirm that my interpretation of the link above 
> is correct (or reasonable).

> I tested that mkvmerge reads the codec point from FFmpeg's files and 
> writes it to files so that FFmpeg can read it.

than it should be ok

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140406/4eac8f2d/attachment.asc>