[FFmpeg-devel] [PATCH] swscale: add API to convert AVFrames directly

[Michael Niedermayer]

On Mon, Sep 30, 2013 at 01:54:28PM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Mon, Sep 30, 2013 at 11:39 AM, Michael Niedermayer <michaelni at gmx.at>wrote:
> 
> > On Sun, Sep 29, 2013 at 08:21:35PM +0200, wm4 wrote:
> > > On Sun, 29 Sep 2013 17:50:52 +0200
> > > Michael Niedermayer <michaelni at gmx.at> wrote:
[...]
> > [...]
> > >  options.c |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > ca2e03fcb8ed9b12e9a96e1d3e97e238dcdf9eff
> >  0001-swscale-make-bilinear-scaling-the-default.patch
> > > From 06ec0cacb9e59c009e61b920c7ac645f5c9fda46 Mon Sep 17 00:00:00 2001
> > > From: wm4 <nfxjfg at googlemail.com>
> > > Date: Sun, 29 Sep 2013 19:52:37 +0200
> > > Subject: [PATCH 1/2] swscale: make bilinear scaling the default
> > >
> > > Before this commit, sws_init_context() failed with an error if no scaler
> > > was explicitly set.
> > >
> > > Defaulting to something reasonable is better behavior.
> > > ---
> > >  libswscale/options.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/libswscale/options.c b/libswscale/options.c
> > > index 8985e6b..2b3147b 100644
> > > --- a/libswscale/options.c
> > > +++ b/libswscale/options.c
> > > @@ -34,7 +34,7 @@ static const char *sws_context_to_name(void *ptr)
> > >  #define VE AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_ENCODING_PARAM
> > >
> > >  static const AVOption swscale_options[] = {
> > > -    { "sws_flags",       "scaler flags",
> >  OFFSET(flags),     AV_OPT_TYPE_FLAGS,  { .i64 = DEFAULT            }, 0,
> >     UINT_MAX,       VE, "sws_flags" },
> > > +    { "sws_flags",       "scaler flags",
> >  OFFSET(flags),     AV_OPT_TYPE_FLAGS,  { .i64  = SWS_BILINEAR       }, 0,
> >       UINT_MAX,       VE, "sws_flags" },
> > >      { "fast_bilinear",   "fast bilinear",                 0,
> >       AV_OPT_TYPE_CONST,  { .i64  = SWS_FAST_BILINEAR  }, INT_MIN, INT_MAX,
> >        VE, "sws_flags" },
> > >      { "bilinear",        "bilinear",                      0,
> >       AV_OPT_TYPE_CONST,  { .i64  = SWS_BILINEAR       }, INT_MIN, INT_MAX,
> >        VE, "sws_flags" },
> > >      { "bicubic",         "bicubic",                       0,
> >       AV_OPT_TYPE_CONST,  { .i64  = SWS_BICUBIC        }, INT_MIN, INT_MAX,
> >        VE, "sws_flags" },
> > > --
> >
> > applied
> 
> 
> Bilinear seems kind of ... poor as a default?

hmm, i guess thats true
patch sent, comments welcome

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130930/23435e85/attachment.asc>