[FFmpeg-devel] [PATCH] Native VP9 decoder.

Ronald S. Bultje rsbultje at gmail.com
Sat Sep 21 21:02:29 CEST 2013


On Sat, Sep 21, 2013 at 2:19 PM, Reimar Döffinger
<Reimar.Doeffinger at gmx.de>wrote:

> On Sat, Sep 21, 2013 at 08:53:09AM -0400, Ronald S. Bultje wrote:
> > +    enum FilterMode filtermode:3;
> I don't think enum bitfields are actually valid C?
> Also, is there a specific reason to use bitfields at all?
> It seems like it won't save all that much, and is one of the
> less reliable things in C compilers in my experience,
> and I believe at least compiling for ARM used to produce
> code with atrocious performance for it (I think basically
> it ended up doing a manual unaligned load of the unsigned).
> No, I am not asking you to change it, but I sure would
> be interested in the reasoning, to me it is still a
> "better save yourself the pain" feature.

No reason at all, just random. We can remove that.


More information about the ffmpeg-devel mailing list