[FFmpeg-devel] [PATCH] lavf: add SFTP protocol via libssh

[Lukasz M]

On 18 September 2013 19:22, Hendrik Leppkes <h.leppkes at gmail.com> wrote:

> On Wed, Sep 18, 2013 at 6:56 PM, Paul B Mahol <onemda at gmail.com> wrote:
> > On 9/18/13, Lukasz Marek <lukasz.m.luki at gmail.com> wrote:
> >> Signed-off-by: Lukasz Marek <lukasz.m.luki at gmail.com>
> >> ---
> >>  Changelog                |    1 +
> >>  configure                |    4 +
> >>  doc/protocols.texi       |   32 +++++++
> >>  libavformat/Makefile     |    1 +
> >>  libavformat/allformats.c |    1 +
> >>  libavformat/libssh.c     |  230
> >> ++++++++++++++++++++++++++++++++++++++++++++++
> >>  6 files changed, 269 insertions(+)
> >>  create mode 100644 libavformat/libssh.c
> >>
> >> diff --git a/Changelog b/Changelog
> >> index 3e4653b..809a1fd 100644
> >> --- a/Changelog
> >> +++ b/Changelog
> >> @@ -25,6 +25,7 @@ version <next>
> >>    more consistent with other muxers.
> >>  - adelay filter
> >>  - pullup filter ported from libmpcodecs
> >> +- SFTP protocol (via libssh)
> >>
> >>
> >
> > Why via wrapper?
> >
> > I do not like wrappers.
>
> Because implementing SFTP requires SSH, and re-implementing SSH would be
> silly.
> I don't like wrappers either, but I like re-implementing such
> complicated things even less.


Yes, it would be an overkill to reimplement it. libssh is also LGPL so it
is not worth IMHO.