[FFmpeg-devel] [PATCH] avfilter: port pullup filter from libmpcodecs

[Reimar Döffinger]

Paul B Mahol <onemda at gmail.com> wrote:
>On 9/18/13, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
>> Paul B Mahol <onemda <at> gmail.com> writes:
>>
>>> On the serious side, if there are issues remaining,
>>> visit trac.ffmpeg.org
>>
>> Sure, but don't you agree that these are issues that should
>> either be addressed before commit or at least agreed that
>> they (for whatever reason) cannot be fixed atm?
>
>You and all the rest of MPlayer tead had almost 10 years to fix
>those issue in mp=pullup itself, and not just in this filter
>but in any other filter and any other part of MPlayer codebase.

I'd appreciate if you could stop with your childish ad-hominem attacks. If you didn't care about the bugs you could just have left libmpcodecs in forever. The whole point of porting is to make the filters acceptable quality for FFmpeg.
What MPlayer does or what bugs it has is fairly irrelevant, it certainly is not an excuse to just ignore bugs "because MPlayer had them for years". Unless you hope for FFmpeg to reach the same code quality.

>If I were in postion to fix all issues that I found I certainly
>would fix them all.

That doesn't explain why it absolutely needed to be committed right now with know leaks.