[FFmpeg-devel] [PATCH] lavc: Don't export?ff_vdpau_vc1_decode_picture

[Thilo Borgmann]

Am 17.09.13 16:48, schrieb Derek Buitenhuis:
> On 9/17/2013 3:37 PM, Thilo Borgmann wrote:
>> I think we should not remove such 'hacks' as long as there is no proper solution
>> for the downstream projects.
>> To get rid of these, nothing holds us back from discussion with - in that case
>> XBMC - to solve the issue instead of just removing them silently and break other
>> projects.
> 
> AFAIK, they only use it in their configure.
              ^^^^                 ^^^^^^^^^
That you know about should be enough not to remove it silently.


>> However, adding new hacks instead should be avoided - I wonder how these came in
>> anyway.
> 
> See 9994643fdd6c06b4f986be8879953a139fbd1a40. Basically, Carl adding hacks inside of
> ffmpeg instead of:
> 
> a) Submiting a patch to XMBC.
> b) Telling them to fix their shit.
> 
> We should *not* be adding this sort of crap.

I don't care who added it - I say that it should have been complained about when
it was to be pushed. Also, you're still trolling which is not helpful.

However, silently removing is even worse - if you want it removed, a) & b) is
either your task then or you should ask Carl-Eugen if he could take care about it.

-Thilo