[FFmpeg-devel] OpenCL: convert meaningless "device id" output to "device name"
Wei Gao
highgod0401 at gmail.com
Tue Sep 17 14:18:21 CEST 2013
2013/9/15 Lenny Wang <lenny at multicorewareinc.com>
> I believe "device name" should use capitalization in consistent with
> "Platform Name".
>
Look good to me, Thanks.
Michaelni, please merge this patch, thanks.
>
> On Sat, Sep 14, 2013 at 7:28 PM, Timothy Gu <timothygu99 at gmail.com> wrote:
> > On Sep 10, 2013 1:09 AM, "highgod0401" <highgod0401 at gmail.com> wrote:
> >
> >> /*
> >> * Use available platform.
> >> */
> >> - av_log(opencl_ctx, AV_LOG_VERBOSE, "Platform Name: %s,
> > device id: 0x%x\n",
> >> + av_log(opencl_ctx, AV_LOG_VERBOSE, "Platform Name: %s,
> > Device Name: %s\n",
> >>
> >
> opencl_ctx->device_list.platform_node[opencl_ctx->platform_idx]->platform_name,
> >> - (unsigned int)opencl_ctx->device_id);
> >> + device_node->device_name);
> >> cps[0] = CL_CONTEXT_PLATFORM;
> >> cps[1] = (cl_context_properties)opencl_ctx->platform_id;
> >> cps[2] = 0;
> >>
> >> Shouldn't the "Device Name" be written as "device name"?
> >
> > Lenny, why don't you fix this capitalization before asking us to apply
> the
> > patch?
> >
> > [...]
> >
> > Timothy
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
More information about the ffmpeg-devel
mailing list