[FFmpeg-devel] [PATCH] matroskaenc: Bump DocTypeVersion to 4

[Hendrik Leppkes]

On Sat, Sep 14, 2013 at 7:57 PM, Alexander Strasser <eclipse7 at gmx.net>wrote:

> On 2013-09-14 01:56 -0300, James Almer wrote:
> > The muxer has been creating files with v4 elements for some time now,
> > and especially now that we can mux non-experimental Opus files, reporting
> > the DocTypeVersion as 2 is not correct.
> >
> > Signed-off-by: James Almer <jamrial at gmail.com>
> > ---
> >  libavformat/matroskaenc.c | 2 +-
> >  tests/ref/lavf/mkv        | 4 ++--
> >  2 files changed, 3 insertions(+), 3 deletions(-)
>
>   Not necessarily related to this patch:
>
>   Do we need to care about DocTypeReadVersion too, or are all produced
> files fine for playback by players that only support version 2. I would
> think so, but I did not investigate. E.g. in the case of Opus, will it
> play (with problems) or not at all.
>
>
All the files are still readable by a (sane) version 2 reader.
Any reader behaving according to spec should just skip unknown elements, so
new elements don't necessarily increase the read version.

Opus would still play, just possibly with minor audio sync issues, and
possible corrupted audio output at start/end and after seeks (the pre-roll
and end padding)

- Hendrik