[FFmpeg-devel] [PATCH] avfilter/vf_noise: remove special code for widths not multiple of 8

[Michael Niedermayer]

On Thu, Sep 12, 2013 at 03:36:43PM +0000, Paul B Mahol wrote:
> On 9/12/13, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Thu, Sep 12, 2013 at 03:28:33PM +0000, Paul B Mahol wrote:
> >> On 9/12/13, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> > On Thu, Sep 12, 2013 at 01:41:56PM +0000, Paul B Mahol wrote:
> >> >> It is not required, as linesize should be aligned to 32.
> >> >>
> >> >> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> >> >> ---
> >> >>  libavfilter/vf_noise.c | 21 ++++-----------------
> >> >>  1 file changed, 4 insertions(+), 17 deletions(-)
> >> >
> >> > breaks handling of images that have width % 8 != 0
> >>
> >> Can you elaborate why you think it breaks when width % 8 != 0?
> >
> > because it writes outside the width x height rectangle
> 
> So you are saying, that one should not touch single bit in padded area?

and from IRC:
> "<durandal_1707> michaelni: how you managed to corrupt picture?"
> * durandal_1707 has quit (Ping timeout: 245 seconds)

consider a interlaced frame

each field can be represented as a linesize = 2*width AVFrame
or in a picture in picture scenario or some case where the padding
contains window manager decorations, ...

[...]

--
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130912/ee44a96d/attachment.asc>