[FFmpeg-devel] [PATCH] avfilter/vf_noise: remove special code for widths not multiple of 8

[Paul B Mahol]

On 9/12/13, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Thu, Sep 12, 2013 at 03:28:33PM +0000, Paul B Mahol wrote:
>> On 9/12/13, Michael Niedermayer <michaelni at gmx.at> wrote:
>> > On Thu, Sep 12, 2013 at 01:41:56PM +0000, Paul B Mahol wrote:
>> >> It is not required, as linesize should be aligned to 32.
>> >>
>> >> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>> >> ---
>> >>  libavfilter/vf_noise.c | 21 ++++-----------------
>> >>  1 file changed, 4 insertions(+), 17 deletions(-)
>> >
>> > breaks handling of images that have width % 8 != 0
>>
>> Can you elaborate why you think it breaks when width % 8 != 0?
>
> because it writes outside the width x height rectangle

So you are saying, that one should not touch single bit in padded area?