[FFmpeg-devel] [PATCH]Change stream id for DTS in mpeg program streams

[Alexander Strasser]

On 2013-09-10 08:01 -0400, compn wrote:
> On Tue, 10 Sep 2013 00:46:22 +0000 (UTC), Carl Eugen Hoyos wrote:
> >Carl Eugen Hoyos <cehoyos <at> ag.or.at> writes:
> >
> >> Attached patch was suggested (and tested) in ticket #1398 (it is not 
> >> related to the ticket), I don't have access to the relevant specification 
> >> but several other open source projects use 0x88 for dts in mpegps.
> >> The relevant original commit is 23c99253.
> >
> >The patch was merged by Michael.
> 
> there were some requests to put entries into our changelog when we
> change the behavior of the program. would something like this be
> acceptable?

  Seems certainly a good idea to mention it.

> diff --git a/Changelog b/Changelog
> index f069145..c4b1251 100644
> --- a/Changelog
> +++ b/Changelog
> @@ -18,6 +18,7 @@ version <next>
>  - DVB teletext decoder
>  - phase filter ported from libmpcodecs
>  - w3fdif filter
> +- change DTS stream id in mpeg ps muxer from 0x8a to 0x88

  OK, with me. Maybe for consistency do not use imperative but
past tense, e.g "changed DTS stream id..."

  Not sure if they are overall consistent. Probably not, so don't
take my comment to serious.

  Alexander
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130910/e118fdfd/attachment.asc>