[FFmpeg-devel] [PATCH] avfilter/yadif: Check more fields for the spatial/temporal decission

[Paul B Mahol]

On 9/5/13, Paul B Mahol <onemda at gmail.com> wrote:
> On 9/5/13, Michael Niedermayer <michaelni at gmx.at> wrote:
>> This increases the in->out delay by 1 frame
>>
>> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
>> ---
>>  libavfilter/vf_yadif.c |   75
>> +++++++++++++++++++++++++++++++++++-------------
>>  libavfilter/yadif.h    |    8 ++++--
>>  2 files changed, 61 insertions(+), 22 deletions(-)
>>

[...]

>>  }
>> @@ -497,7 +532,7 @@ static int config_props(AVFilterLink *link)
>>  #define CONST(name, help, val, unit) { name, help, 0, AV_OPT_TYPE_CONST,
>> {.i64=val}, INT_MIN, INT_MAX, FLAGS, unit }
>>
>>  static const AVOption yadif_options[] = {
>> -    { "mode",   "specify the interlacing mode", OFFSET(mode),
>> AV_OPT_TYPE_INT, {.i64=YADIF_MODE_SEND_FRAME}, 0, 3, FLAGS, "mode"},
>> +    { "mode",   "specify the interlacing mode", OFFSET(mode),
>
> The way how this is documented and presented to the user is far from
> optimal.
>
> If it is flag then it should be set like that and not by adding extra
> modes.
>

Actually I see it is too late for such change.

It would be better if such 'modes' are also listed/mentioned in above options.

[...]