[FFmpeg-devel] [PATCH] opus/matroska: Adding support for End Trimming in demuxer/decoder

[Nicolas George]

L'octidi 18 fructidor, an CCXXI, Michael Niedermayer a écrit :
> i confirm this fixes the issues
> 
> anyone else has any comments about the patchset ?
> nicolas ? you worked with (lib)opus IIRC

I worked on the decoder, not the encoder. Assuming I understand correctly
what ff_af_queue does, the libopusenc part looks fine (except style:
"uint8_t* side_data" -> "uint8_t *side_data" and "side_data == NULL" ->
"!side_data").

I can not comment usefully on the Matroska part, though. It looks fine at
first glance, but I would not spot a subtle mistake.

The "(side_data_size && additional_id == 1)" and "(side_data_size &&
additional_id == 1) || discard_padding" tests look a bit fragile, and may
become a maintenance burden. Maybe checking block_group to see if it was
opened or setting a flag at the same time would be cleaner. But that does
not change the logic of the code.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130905/a8b4652b/attachment.asc>