[FFmpeg-devel] [PATCH] lavfi: Weston 3 Field Deinterlacing Filter

[Timothy Gu]

This is only a review for the documentation.

On Sep 4, 2013 6:51 PM, "Paul B Mahol" <onemda at gmail.com> wrote:
>
> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> ---
>  LICENSE                  |   1 +
>  configure                |   1 +
>  doc/filters.texi         |  25 ++++
>  libavfilter/Makefile     |   1 +
>  libavfilter/allfilters.c |   1 +
>  libavfilter/vf_w3fdif.c  | 361
+++++++++++++++++++++++++++++++++++++++++++++++
>  6 files changed, 390 insertions(+)
>  create mode 100644 libavfilter/vf_w3fdif.c
>
> diff --git a/LICENSE b/LICENSE
> index 12b08c2..3405d44 100644
> --- a/LICENSE
> +++ b/LICENSE
> @@ -47,6 +47,7 @@ Specifically, the GPL parts of FFmpeg are
>      - vf_stereo3d.c
>      - vf_super2xsai.c
>      - vf_tinterlace.c
> +    - vf_w3fdif.c
>      - vf_yadif.c
>      - vsrc_mptestsrc.c
>
> diff --git a/configure b/configure
> index 4ff97b4..fcb96eb 100755
> --- a/configure
> +++ b/configure
> @@ -2233,6 +2233,7 @@ super2xsai_filter_deps="gpl"
>  tinterlace_filter_deps="gpl"
>  vidstabdetect_filter_deps="libvidstab"
>  vidstabtransform_filter_deps="libvidstab"
> +w3fdif_filter_deps="gpl"
>  yadif_filter_deps="gpl"
>  pixfmts_super2xsai_test_deps="super2xsai_filter"
>  tinterlace_merge_test_deps="tinterlace_filter"
> diff --git a/doc/filters.texi b/doc/filters.texi
> index 8f1446d..64e2208 100644
> --- a/doc/filters.texi
> +++ b/doc/filters.texi
> @@ -7832,6 +7832,31 @@ vignette='PI/4+random(1)*PI/50':eval=frame
>
>  @end itemize
>
> + at section w3fdif

nit: add a new line here

> +Deinterlace the input video.

nit: here too.

> +"w3fdif" stands for "Weston 3 Field Deinterlacing Filter".
> +
> +Based on the process described by Martin Weston for BBC R&D, and
> +implemented based on the de-interlace algorithm written by Jim
> +Easterbrook for BBC R&D, the Weston 3 field deinterlacing filter
> +uses filter coefficients calculated by BBC R&D.
> +
> +There are two sets of filter coefficients, so called "simple:

Typo: s/"simple:/"simple"

> +and "complex". Which set of filter coefficients is used can
> +be set by passing an optional parameter:
> +
> + at table @option
> + at item filter
> +The interlacing filter coefficients, accepts one of the following values:
> + at table @samp
> + at item simple
> +simple filter coefficient set

nit: missing period ('.')

> + at item complex
> +more-complex filter coefficient set

here too

> + at end table
> +Default value is @samp{complex}.
> + at end table
> +
>  @anchor{yadif}
>  @section yadif

[...]

Can't comment on anything else.

Timothy