[FFmpeg-devel] [PATCH] opus/matroska: Adding support for End Trimming in demuxer/decoder

Michael Niedermayer michaelni at gmx.at
Tue Sep 3 01:30:48 CEST 2013


On Fri, Aug 30, 2013 at 11:25:12AM -0700, Vignesh Venkatasubramanian wrote:
> Implementing support for end trimming Opus in Matroska by making
> use of the DiscardPadding value from the container and discarding
> the samples accordingly. With this patch and its companion muxer
> patch, we can ensure number of samples in == number of samples out
> for Opus in Matroska.
> 
> Signed-off-by: Vignesh Venkatasubramanian <vigneshv at google.com>
> ---
>  libavcodec/utils.c        | 21 +++++++++++++++++++++
>  libavformat/matroskadec.c | 30 +++++++++++++++++++++++++-----
>  2 files changed, 46 insertions(+), 5 deletions(-)

this (with the other patched) causes fate to fail
--- ./tests/ref/fate/exif-image-embedded    2013-09-02 12:10:30.045471774 +0200
+++ tests/data/fate/exif-image-embedded 2013-09-03 01:29:07.774481269 +0200
@@ -34,7 +34,7 @@
 pkt_pos=16292
 pkt_size=417
 sample_fmt=s16p
-nb_samples=47
+nb_samples=-11006
 channels=2
 channel_layout=stereo
 [/FRAME]

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130903/c45cfd86/attachment.asc>


More information about the ffmpeg-devel mailing list