[FFmpeg-devel] [PATCH]Fix deadlock in wma decoder

Michael Niedermayer michaelni at gmx.at
Sun Sep 1 18:22:10 CEST 2013


On Sun, Sep 01, 2013 at 04:40:36PM +0200, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch fixes ticket #2925 here.
> 
> Please comment, Carl Eugen

looks good but shouldnt this be treated as an error instead of just
continuing (and failing randomly later i assume) ?

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130901/4278d76c/attachment.asc>


More information about the ffmpeg-devel mailing list