[FFmpeg-devel] [PATCH] some image will set 0 length exif tag

Michael Niedermayer michaelni at gmx.at
Thu Oct 31 23:37:44 CET 2013


On Thu, Oct 31, 2013 at 11:03:04AM +0800, William Yu wrote:
> 2013/10/30 Thilo Borgmann <thilo.borgmann at mail.de>
> 
> > Am 30.10.13 04:38, schrieb William Yu:
> > > Some image tools add 0 length tag to file. I think ignore these tag is
> > > better than failed.
> > >
> > > Signed-off-by: William Yu <genwillyu at gmail.com>
> > > ---
> > >  libavcodec/exif.c | 5 ++++-
> > >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > There are some problems applying your patch:
> >
> > 0001-some-image-will-set-0-length-exif-tag.patch:10: trailing whitespace.
> >         if (ret > 0) {
> > 0001-some-image-will-set-0-length-exif-tag.patch:11: trailing whitespace.
> >             ret = exif_add_metadata(avctx, count, type, use_name, NULL,
> > 0001-some-image-will-set-0-length-exif-tag.patch:13: trailing whitespace.
> >         } else
> > 0001-some-image-will-set-0-length-exif-tag.patch:14: trailing whitespace.
> >             ret = 0;
> > error: patch failed: libavcodec/exif.c:93
> > error: libavcodec/exif.c: patch does not apply
> >
> >
> > Please resolve these and resubmit.
> >
> > -Thilo
> >
> 
> Attached new patch has been cleaned up.

alternative patch in
[PATCH] avcodec/tiff_common: allow count = 0 in ff_tadd_bytes_metadata()

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131031/4d5e7ffe/attachment.asc>


More information about the ffmpeg-devel mailing list