[FFmpeg-devel] [PATCH 1/2] avcodec/options_table: disable CRC checking by default

[Michael Niedermayer]

On Sun, Oct 27, 2013 at 07:53:27PM +0000, Paul B Mahol wrote:
> On 10/27/13, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Sun, Oct 27, 2013 at 06:55:06PM +0000, Paul B Mahol wrote:
> >> On 10/27/13, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> > On Sun, Oct 27, 2013 at 05:11:18PM +0000, Paul B Mahol wrote:
> >> >> On 10/27/13, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> >> > From: Anton Khirnov <anton at khirnov.net>
> >> >> >
> >> >> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> >> >> > ---
> >> >> >  libavcodec/options_table.h |    2 +-
> >> >> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >> >> >
> >> >>
> >> >> useless pointless bad
> >> >
> >> > its reqired for hevc, otherwise some hevc will be kind of slow.
> >>
> >> numbers please!
> >
> > its my pleassure
> >
> > 3 runs each of fate-suite/hevc-conformance/ENTP_C_LG_3.bit
> >
> > with crc flag
> > 1841819858 decicycles in frame decode, 32 runs, 0 skips
> > 1833937180 decicycles in frame decode, 32 runs, 0 skips
> > 1843283884 decicycles in frame decode, 32 runs, 0 skips
> >
> > without crc flag
> > 1703897301 decicycles in frame decode, 32 runs, 0 skips
> > 1695031879 decicycles in frame decode, 32 runs, 0 skips
> > 1697524383 decicycles in frame decode, 32 runs, 0 skips
> 
> Not much.

for a useless computation (from the end users point of view)
in a major codec, its enough.

applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131027/f922b9b2/attachment.asc>