[FFmpeg-devel] [PATCH] build: don't print brief make messages for empty variables

[Michael Niedermayer]

On Wed, Oct 23, 2013 at 02:24:45PM +0200, Ingo Brückl wrote:
> This won't give false information to the user in case a variable isn't
> defined (although this isn't the case yet), and - more important - it
> will allow proper checking for variables as in commit e52567c2954f627d.
> ---
>  common.mak |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common.mak b/common.mak
> index 6479b08..ccc3b55 100644
> --- a/common.mak
> +++ b/common.mak
> @@ -16,7 +16,7 @@ SILENT = DEPCC DEPHOSTCC DEPAS DEPYASM RANLIB RM
>  MSG    = $@
>  M      = @$(call ECHO,$(TAG),$@);
>  $(foreach VAR,$(BRIEF), \
> -    $(eval override $(VAR) = @$$(call ECHO,$(VAR),$$(MSG)); $($(VAR))))
> +    $(if $($(VAR)),$(eval override $(VAR) = @$$(call ECHO,$(VAR),$$(MSG)); $($(VAR)))))

this doesnt seem to work or i misunderstand its use

when i remove STRIP=.., from config.mak and run make then instead
of strip it actually runs ffmpeg

make V=2 ffmpeg
cp -p ffmpeg_g ffmpeg
ffmpeg
ffmpeg version N-52038-g9b595e8 Copyright (c) 2000-2013 the FFmpeg developers
  built on Apr 12 2013 21:41:02 with gcc 4.6 (Ubuntu/Linaro 4.6.3-1ubuntu5)
...


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131024/ec4a9979/attachment.asc>