[FFmpeg-devel] [PATCH] avcodec/metasound_data: Fix inconsistency in tables

Michael Niedermayer michaelni at gmx.at
Wed Oct 23 12:31:37 CEST 2013


On Wed, Oct 23, 2013 at 08:03:36AM +0000, Paul B Mahol wrote:
> On 10/22/13, Michael Niedermayer <michaelni at gmx.at> wrote:
> > Fixes out of array read
> 
> How and why this fixes out of array read?

fcb16m has 320 elements but the code before the patch can address a
table of 384 elements in its place.
I dont know if theres some elements missing, or its maybe the wrong
table, or if this patch is the correct fix, or if theres something
else wrong
which is why ive posted it here ... hoping someone reading this has
easy access to some reference. (binary with the tables in it, spec,
whatever)




> 
> >
> > This issue can be reproduced with:
> > Lucky.asf
> > teuflisch.asf
> > from http://samples.ffmpeg.org/A-codecs/VoxWare/
> >
> > as well as other samples
> >
> > Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> >  libavcodec/metasound_data.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavcodec/metasound_data.c b/libavcodec/metasound_data.c
> > index 3465499..2a9fa33 100644
> > --- a/libavcodec/metasound_data.c
> > +++ b/libavcodec/metasound_data.c
> > @@ -5056,7 +5056,7 @@ const TwinVQModeTab ff_metasound_mode0808 = {
> >  const TwinVQModeTab ff_metasound_mode1616 = {
> >      {
> >          { 8, bark_tab_s16_128,  10, fcb16s, 1, 5, cb1616s0, cb1616s1, 16
> > },
> > -        { 2, bark_tab_m16_512,  24, fcb16m, 2, 5, cb1616m0, cb1616m1, 15
> > },
> > +        { 2, bark_tab_m16_512,  20, fcb16m, 2, 5, cb1616m0, cb1616m1, 15
> > },
> >          { 1, bark_tab_l16_1024, 30, fcb16l, 3, 6, cb1616l0, cb1616l1, 16 }
> >      },
> >      1024, 16, lsp16, 1, 6, 4, 3, shape16, 9, 28, 30, 7, 200
> > --
> > 1.7.9.5
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131023/05f6997c/attachment.asc>


More information about the ffmpeg-devel mailing list