[FFmpeg-devel] [PATCH 4/4] h264: Check all allocations
Derek Buitenhuis
derek.buitenhuis at gmail.com
Wed Oct 23 01:18:46 CEST 2013
On 10/22/2013 10:20 PM, Michael Niedermayer wrote:
>> @@ -1738,11 +1743,15 @@ static int decode_update_thread_context(AVCodecContext *dst,
>> h->mb_stride = h1->mb_stride;
>> h->b_stride = h1->b_stride;
>> // SPS/PPS
>> - copy_parameter_set((void **)h->sps_buffers, (void **)h1->sps_buffers,
>> - MAX_SPS_COUNT, sizeof(SPS));
>> + if ((ret = copy_parameter_set((void **)h->sps_buffers,
>> + (void **)h1->sps_buffers,
>> + MAX_SPS_COUNT, sizeof(SPS))) < 0);
>> + return ret;
>
> you have a ; too much here
>
>
>> h->sps = h1->sps;
>> - copy_parameter_set((void **)h->pps_buffers, (void **)h1->pps_buffers,
>> - MAX_PPS_COUNT, sizeof(PPS));
>> + if ((ret = copy_parameter_set((void **)h->pps_buffers,
>> + (void **)h1->pps_buffers,
>> + MAX_PPS_COUNT, sizeof(PPS))) < 0);
>> + return ret;
>
> and here
Both fixed locally.
- Derek
More information about the ffmpeg-devel
mailing list