[FFmpeg-devel] [PATCH] configure: enable libavresample by default
nfxjfg at googlemail.com
Mon Oct 21 23:10:42 CEST 2013
On Mon, 21 Oct 2013 22:15:12 +0200
Michael Niedermayer <michaelni at gmx.at> wrote:
> On Mon, Oct 21, 2013 at 08:53:24PM +0200, wm4 wrote:
> > On Mon, 21 Oct 2013 20:34:49 +0200
> > Michael Niedermayer <michaelni at gmx.at> wrote:
> > > Thats a long list, but i think for discussing the change of
> > > avresamples default build status, theres one keypoint missing
> > > and that is who would maintain it ?
> > Libav. You're not making any changes to libavresample, so merging
> > Libav's maintenance patches is no additional work.
> So you do not volunteer to do the work and you explain me how it will
> be no additional work for me? (why dont you volunteer if its no work?)
> you seem to assume we dont fix any security issues, fix no bugs,
> review no patches and hope it will still build with our build system
> in the future.
But just disabling libavresample makes all this better?
What if someone enables libavresample using --enable-avresample, and
there's a bug? Will you fix it? Will you just say you don't care
because it's not enabled by default?
> In reality, libavresample doest even pass its selftests in ffmpeg
> thats today, no future hypothethical stuff
> who will fix that ?
You're saying that libavresample doesn't pass the tests Libav added?
Which I find funny, because your commit adding the libswresample tests
say they're based on libavresample's - so you spent some work on it,
but the benefit went only to libswresample, not libavresample.
> I do maintain swresample, if it doesnt work i will fix it, if
> avresample is better in some way i will improve swresample.
Then give it exactly the same API as libavresample.
> If the hostilities stop and libav wants to cooperate iam not opposed
> to see the libs merge. If anyone wants to maintain code, all
> the better, doesnt matter from which if any project he is
I don't know, libavcodec, libavutil, libavformat, libavfilter,
libavdevice, libswscale are all maintained by both FFmpeg and Libav.
Why not the resample library? Is it a particularly important component?
I don't think so, because ffmpeg's main task is still decoding, and
that is in libavcodec.
> > > though i guess this direction of argumentation doesnt lead anywhere
> > > i find your "inflicting pain" and politics chatter a bit lame
> > I find it a bit lame that a small patch to make the life of every
> > ffmpeg/libav user easier requires so much discussion.
> calm down please
> avresample being built by default makes your life easier in the short
> and it would help some others, it wont help every user
> also if for example ubitux prediction is correct and it kills
> swr then you end up with a codebase which maybe noone from ffmpeg
> will maintain. That doesnt sound like a particularly good long term
> outcome for ffmpeg users.
> > And there's no doubt, your political games do cause additional work for
> > users.
> I suggest we skip the political trolling and try to solve the problems
More information about the ffmpeg-devel