[FFmpeg-devel] Add version numbers information for Windows binaries

[Timothy Gu]

On Oct 16, 2013 5:11 PM, "Michael Niedermayer" <michaelni at gmx.at> wrote:
>
> On Wed, Oct 16, 2013 at 06:10:40PM -0300, James Almer wrote:
> > On 16/10/13 4:24 PM, Michael Niedermayer wrote:
> > > On Wed, Oct 16, 2013 at 11:02:58AM -0800, Lou Logan wrote:
> > >> On Wed, 16 Oct 2013 01:41:02 -0700 (PDT), Nguyen Trong Tuan wrote:
> > >>
> > >>> Please add version numbers information for Windows binaries.
> > >>> That will be very helpful for users.
> > >>
> > >> FFmpeg does not provide any binaries (only source code), but
> > >> there are some available for Windows at:
> > >> http://ffmpeg.zeranoe.com/builds/
> > >>
> > >> The binary will tell you the version number in the console output:
> > >
> > > maybe i misunderstand but dont windows exes have some version metadata
> > > in them? and if i remember that right, do we set that ?
> > > If we dont, then we should, and someone should fix that (not me
> > > as iam no windows devel)
> >
> > If you mean embedded resource data in an exe or dll, then no, we don't
> > set that.
> >
>
> > I submitted a patch to add support for that using GNU windres some time
> > ago. I can rebase it and submit it again for review if there's interest.
>
> i think its a good idea but i dont know if everyone else likes it.

Sherpya has already done it.
https://github.com/sherpya/FFmpeg/commit/558e29b7c2dd609c3525f4cf78cc9af2aab1dea0

Timothy