[FFmpeg-devel] Patch to fix RTMP URI parsing

Lukasz M lukasz.m.luki at gmail.com
Wed Oct 16 14:45:45 CEST 2013


On 16 October 2013 14:28, Anders Rein <are at vizrt.com> wrote:

> When parsing RTMP URI, ffmpeg concatenates a string after allocating it
> with av_malloc before setting the first character to zero. Valgrind shows
> this as "conditional jump or move depends on uninitialised value(s)". On
> some systems (like mine), this can cause random ascii characters in the
> filename being sendt to the RTMP streaming server.
>
> This patch fixes this problem.
>
> --- a/libavformat/rtmpproto.c
+++ b/libavformat/rtmpproto.c
@@ -2506,6 +2506,7 @@ reconnect:
             ret = AVERROR(ENOMEM);
             goto fail;
         }
+        rt->playpath[0] = '\0'

missing semicolon at the end of the line.
Looks like last else statement below can be removed too.


More information about the ffmpeg-devel mailing list