[FFmpeg-devel] [PATCH 1/3] avfilter/vf_telecine: use the name 's' for the pointer to the private context

Stefano Sabatini stefasab at gmail.com
Sun Oct 13 16:18:45 CEST 2013

On date Friday 2013-10-11 11:40:41 +0000, Paul B Mahol encoded:
> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> ---
>  libavfilter/vf_telecine.c | 110 +++++++++++++++++++++++-----------------------
>  1 file changed, 55 insertions(+), 55 deletions(-)

I'm mildly against renames to a meaningless single char, especially
given that the context is private and can't be copy pasted to other
part of the code, and makes it harder to read the code out-of-context
(e.g. in a patch). This also adds unnecessary code churnup for the
sake of one character to type.

That said, I'm no maintainer of the code in question.
FFmpeg = Frenzy Funny Mastodontic Problematic Elected Ghost

More information about the ffmpeg-devel mailing list