[FFmpeg-devel] [PATCH 1/4] lavd/pulse_audio_enc: rename device param into audio_device
lukasz.m.luki at gmail.com
Fri Oct 11 16:35:12 CEST 2013
On 11 October 2013 14:05, Paul B Mahol <onemda at gmail.com> wrote:
> On 10/11/13, Stefano Sabatini <stefasab at gmail.com> wrote:
> > On date Friday 2013-10-11 11:31:03 +0000, Paul B Mahol encoded:
> >> On 10/11/13, Stefano Sabatini <stefasab at gmail.com> wrote:
> >> > On date Friday 2013-10-11 00:39:36 +0200, Lukasz Marek encoded:
> >> >> device may refer for both audio and video device.
> >> >> audio_device is clear.
> >> >
> >> > OTOH given that this is an audio device this is probably redundant.
> >> >
> >> > This is also technically an API break, need a micro bump.
> >> API breaks are done with major bump.
> > Given that the device was committed a few days ago, should not really
> > be a problem. Alternatively, create an alias if you insist with the
> > long name.
> What about: pulse_decode_audio_output_device?
> Now you can know what it is from command line.
> I'm against such renames.
> Related options should be grouped together on command line.
> Limitations of ffmpeg command line syntax should not add redundant
> prefixes to options.
More information about the ffmpeg-devel