[FFmpeg-devel] [PATCH] Generalize ATRAC3 gain compensation

[Michael Niedermayer]

On Wed, Oct 02, 2013 at 02:38:22AM +0200, Maxim Polijakowski wrote:
> Hi crews,
> 
> this patch set splits out ATRAC3 gain compensation code, generalize
> it for using both in the existing ATRAC3 decoder and the upcoming
> ATRAC3+ decoder and move it to the ATRAC common code.
> 
> Best regards
> Maxim

[...]

patches split and applied
i ommited some cosmetics and fixed minor things

also for future patches, please try to seperate unrelated changes into
seperate patches 
"git add -p" makes that quite easy

Two unlreated changes i would suggest are to

possibly rename gain_tab2 to gain_interpol(_tab)

and to add const to the pointer arguments of functions when they arent
changed by the function
that way a reader can see which arrays arent changed by a function
and it may help the compiler generate faster code as well


thanks


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131002/8e59e86e/attachment.asc>