[FFmpeg-devel] [RFC][PATCH] version.sh: Include annotated tag in version string

[Alexander Strasser]

On 2013-11-29 18:56 +0100, Nicolas George wrote:
> Le nonidi 9 frimaire, an CCXXII, Alexander Strasser a écrit :
> >   It was empty but it is set in the line above and extended in
> > the line my patch added.
> 
> Oh, yes, my bad: I thought it was a changed line (- on the previous line, +
> on this one), but it is just an insertion. Forget my comment and sorry for
> the noise.

  Not that useless noise indeed.

  To be sure I took another look at that file. I wonder if the whole
condition can be dropped and the modified branch can be executed
unconditionally.

  Should be OK if no-one is injecting the revision variable through the
environment. From what I see in the history for now, it came in this
shape on a merge. Did not check the deeper details yet.


  Alexander
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131129/ea859ca0/attachment.asc>